Add tado service set temperature offset #45014
Conversation
|
Hi @north3221, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
|
Hey there @michaelarnauts, @bdraco, mind taking a look at this pull request as its been labeled with an integration ( |
MartinHjelmare
changed the title
|
I've added some code to get the current offset and add it as an attribute on the zone. I'm not convinced its the best way to do it, as maybe making another change to PyTado to add it to the TadoZone object might be better, but the issue there is the zone doesn't have knowledge of the device to get the offset... The way I have done it works. I have put it as an output to in 'device_state_attributes' as that seems like the logical place? Unless I am misunderstanding the docs (I've very new to this and my first HA PR), you can't create your own properties so need to use standard climate ones? Alternatively could set up on individual devices, but they have been set as binary_sensors, doesnt feel right. I think maybe adding devices to zones as that's how Tado see them may be better, but that's a fundamental change to how this is set up. Anyhow it works :-) I'll push the commit and can undo that commit if that part isn't accepted and do a separate PR for it a different way depending on feedback. |
|
Ahh should of added some constants to .const for that... I'll let someone review and see if there is anything else to fix and do at same time |
|
@MartinHjelmare fab thanks for all the help. Think that should now do it. |
|
Ignore... I worked it out (I think) - feedback very welcome on the commit to add it Hey could anyone help explain how I make the service accept a template? I tried and failed.... OR point me at docs that explain it... It didn't seem to be there is the developer docs. It seems if I change it to allow string or template it passes it as a full string of the template, not the value of the template or errors with 'Object of type Template is not JSON serializable'. Assume not as straightforward as I thought? So do you allow string then write code in your function to test for template and execute template to get he value then validate value? I kinda expected I could say accept float or template that results in float? |
|
Please document the new service and add a link to the docs PR in this PR description: We can merge when that is done and code owner approves. |
Sorry been a mental week, finally got round to doing this and added link. NB the pr has a label of 'current' but I ticked the 'documenting new feature I am adding', which I thought would make it 'next' branch. Not sure if I did something wrong? |
|
Raised a new doc pr as couldn't change to next in the gui, updated link in this one to correct docs pr hopefully now should all be good to go |
|
@bdraco and @michaelarnauts ok to merge? |
|
This looks fine! |
MartinHjelmare
changed the title
|
Just noticed a duplicate feature request for this: https://community.home-assistant.io/t/tado-integration-put-offset/175964/3 Not sure if the feature requests threads get closed after implementation? Is so just adding here so it can be closed |
Proposed change
Tado devices have a temperature offset which Home Assistant currently cannot change, this PR provides the ability to change the offset value with a new service. This will let people adjust the offset with automations, using other devices to decide the offset
Type of change
Example entry for
configuration.yaml:# Example configuration.yamlAdditional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: